cafe78b9ec84416409dd95c8469f3385db6f1060
[blog.git] / _posts / 2008-05-10-the_annoying_continues_ftpmast.markdown
1 ---
2 layout: post
3 title: 'The annoyance continues: Ftpmaster, yet again'
4 date: '2008-05-10 18:48:00 +0000'
5 mt_id: 224
6 blog_id: 1
7 post_id: 224
8 basename: the_annoying_continues_ftpmast
9 categories:
10 - ftpmaster
11 ---
12 Lalala, it's me again. Don't shout, it's not a long post! :)
13
14 What did we do since I last dared to post with my Ftpmaster head on?
15 (Yes, I should put a summary of all my blog posts into a *Bits from* mail sometime.)
16
17 - Fixed some bugs, like all of the waiting *Please create/remove pseudopackage FOO* ones. So we now have a BTS entry for wiki.debian.org, release.debian.org and the security-tracker.
18
19 - Merged a patch from Thomas so we now correctly reject packages where the maintainer tried to be clever, editing the changes file to get an orig.tar.gz mentioned after forgetting the -sa parameter to dpkg-buildpackage. **SIGH**. Especially **sigh** as that \#\#censored\#\# wasn't able to understand the format of those lines. Nor did he look, or he would have immediately spotted his mistake. Unfortunately it is not the first time this maintainer broke stuff with uploads he **never** checked in any way. Including uploads for important packages. Bah.
20
21 - Merged another patch from Thomas, which generally makes NEW look nicer. It drops the unneeded Checksums-foo headers completly, no need that we see them there again, they just waste space and are useless for us. The patch also changes the html files we generate for all packages in NEW, something which I [added to dak](http://blog.ganneff.de/blog/2007/12/30/html-output-for-packages-in-ne.html) a few months ago - based on a patch from Thomas. :)
22
23 The stylesheet now applied got sent in from
24 [Martín Ferrari](http://beta.howtorecognise.mine.nu/blog) who already created the style for the [removals page](http://ftp-master.debian.org/removals.html).
25
26 - Done a whole lot of NEW. Yes, I continue to do most of NEW, as I'm still (and possibly for some time) are the one with the most experience and speed in doing it. Thomas is doing NEW too, mostly by picking a few packages and processing them. (Before someone yells - he is doing a very good job with removals and override changes, an area where I haven't looked much into since he got added to the ftpteam).
27
28 - Did, together with Mark Hymers, a lot of cleanup work in the code, using pychecker and pylint. We only started, but there have been various changes already, like
29
30 - change "import daklib.foo" and then using daklib.function to "from daklib import foo" and then using foo.function. Granted, the **Ideal** way would be to go "from daklib.foo import function1, function2, function3" (or so), explicitly naming every thing you use. Or even better, make the whole dak fully object oriented. Or so. Or whatever. :)
31 - replaced all own string exceptions, which are *deprecated*, with real exception classes.
32
33 The cleanups we did made pylint rate the code 5.21, with the initial rating (before we did anything cleanup related) was 3.59/10. (As if it would count, but still) :)
34
35 - Added two more headers to mails generated by dak and the queue daemon, **X-Debian: DAK** and **X-Debian-Package: $something**, following a suggestion from [Bug \#479953](http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=479953). Hopefully other tools follow this schema too, at least I announced it on [debian-devel-announce](http://lists.debian.org/debian-devel-announce/2008/05/msg00001.html), so hopefully it will be taken as a quasi-standard. :)
36
37 Ok, yes, I admit, the queue daemon is currently **not** adding the X-Debian-Package header. It *does* add the X-Debian: DAK header, but not the package one. I got a headache when looking at it, its old and *grown* perl code. If someone wants to send a patch, fine, the [bzr repository](http://ftp-master.debian.org/bzr/ftpmaster-dak/) has it in tools/debianqueued-0.9.
38
39 **Update**: Now the queue daemin also adds the X-Debian-Package header as I got two patches addressing the issue, in two different ways. Thanks to Stephen Gran and Matt Kraai for their work!
40
41